Skip to content

Add additional comment about Prerequisite to README#343

Merged
jackycute merged 3 commits intohackmdio:masterfrom
sakajunquality:feature/fix-read-me-for-gcc
Feb 8, 2017
Merged

Add additional comment about Prerequisite to README#343
jackycute merged 3 commits intohackmdio:masterfrom
sakajunquality:feature/fix-read-me-for-gcc

Conversation

@sakajunquality
Copy link
Copy Markdown
Contributor

make and gcc are required in node-gyp.

Without these packages, bin/setup ,which is instructed in Get started will fail.

@jackycute
Copy link
Copy Markdown
Member

jackycute commented Feb 6, 2017

Thanks @sakajunquality , this might be useful.

But I think it's better just reference link to prerequisite of node-gyp (or other dependencies).
And also we require gcc >= 4.8 because of uWebSocket https://github.com/uWebSockets/uWebSockets#nodejs-developers
Also the phantomjs is required of PDF generating, that is phantomjs-prebuilt which not support all OS platforms or CPUs.

@sakajunquality sakajunquality force-pushed the feature/fix-read-me-for-gcc branch from 524d7af to 2ab57ef Compare February 8, 2017 06:30
@sakajunquality
Copy link
Copy Markdown
Contributor Author

@jackycute Thank you for your comment.
I changed that part for just referencing to some packages.

@jackycute
Copy link
Copy Markdown
Member

Appreciated @sakajunquality

@jackycute jackycute merged commit 6587e7c into hackmdio:master Feb 8, 2017
@sakajunquality sakajunquality deleted the feature/fix-read-me-for-gcc branch February 8, 2017 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants